If you would normally expect to pay to stay onproperty at WDW at a deluxe (or perhaps, moderate) resort at least every other year, then YES, it's something you should definitely consider!
As mentioned above, it's a lesser value for someone who wants to buy it for exchanging or use outside DVC resorts. If you would be happy staying at a room or two at the All Stars, or a discounted room at the Swan/Dolphin or a beautiful offsite timeshare villa or seeking bargain rates for less frequent WDW trips or you are not confident that your interest in returning to WDW will continue, DVC may be a rather expensive way to go, IMHO. As flexibile as it is, nothing beats the flexibility of renting when and where you want. ...Unless of course, you fall in love with a particular resort and you just want to return there and own there and enjoy it as a "second home." Then the money is well spent, IMHO.
We are a family of five who discovered after buying DVC, that it was too expensive for US. So we sold it. The DVC resorts are fantastic and the program is great! But it was just too much $ for us. We'd need a 2-BR villa, ~300 points for a week every year. The purchase cost for our annual DVC 2-BR week, even on a resale is about $17,000-$22,000, plus $900-$1,200 per year in maint fees. By contrast, we have enjoyed some wonderful vacations offsite and spent $2,000 purchase, plus $350 in annual costs by trading via RCI from other areas. Since we've enjoyed the offsite resorts as much as we have, the difference in cost was not worth the convenience of onsite. And we still take advantage of great discounts when they are available to extend our trips with a couple of days at an onsite Disney hotel. Further, we have gotten discounted rental rates and traded into DVC Hilton Head Island (our favorite DVC resort) via II in a quieter season and had a wonderful time there despite not being members any longer.
It all depends on your situation. See if you fit the profile of the happy DVC'ers who would benefit financially and enjoy a DVC membership. There are plenty of them.