I think it really depends on what one defines as a "tourist trap." To me, it's not always a whole city but maybe one part of it. I'm thinking of places that sell CHEAP souvenirs and clothing that just has the name of the city on them. This is what I think of when I hear "tourist trap"...
View attachment 261573 View attachment 261576
These are images from Wisconsin Dells. True, there are some fun things and even some really classy things (Sundara Spa, for example) in the Dells that you can't find elsewhere, but the main street shown in the picture is a classic example of a tourist trap. Generic stores, tourist experiences (Ripley's Believe it or Not, Madame Tussaud's, etc.), crappy motels, etc.
I would not call Disney World a "tourist trap" by my definition.
I was just in San Francisco last week and was really disappointed by Fisherman's Wharf - what a trap. There were lots of crappy tourist stores. We were not even impressed by Boudin's sourdough bread bowls filled with clam chowder (could NOT compare to Anchor Oyster Bar's!). At least there were sea lions!
View attachment 261584